Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move twitch login to backend API call, rather than exposing access to… #30

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

saebyn
Copy link
Owner

@saebyn saebyn commented Jan 5, 2025

…ken in URL in browser

Fixes saebyn/glowing-telegram#311

@saebyn saebyn self-assigned this Jan 5, 2025
@Copilot Copilot bot review requested due to automatic review settings January 5, 2025 23:37

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 21 out of 36 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • .env.defaults: Language not supported
  • .vscode/tasks.json: Language not supported
  • src/components/atoms/TwitchTokenLivenessChecker.tsx: Evaluated as low risk
  • src/components/organisms/SRTExporter/ExportButton.tsx: Evaluated as low risk
  • src/components/organisms/TasksDrawer/useTasks.ts: Evaluated as low risk
  • src/components/organisms/TasksDrawer/List.tsx: Evaluated as low risk
  • src/components/organisms/OTIOExporter/mediaClipSequence.ts: Evaluated as low risk
  • src/components/organisms/Timeline/DensityLine.stories.tsx: Evaluated as low risk
  • src/components/organisms/Timeline/SegmentSelector.stories.tsx: Evaluated as low risk
  • src/components/pages/ProfilePage.tsx: Evaluated as low risk
  • src/components/molecules/AdManager.tsx: Evaluated as low risk
  • src/components/atoms/TwitchOAuthButton.tsx: Evaluated as low risk
  • src/App.tsx: Evaluated as low risk
  • src/components/atoms/TwitchCategoryAutocompleteInput.tsx: Evaluated as low risk
  • src/components/atoms/TwitchCCLSelect.tsx: Evaluated as low risk
Comments suppressed due to low confidence (3)

src/api.ts:36

  • Ensure that the fetchTwitchAccessToken function is covered by tests to verify its behavior.
export async function fetchTwitchAccessToken(): Promise<TwitchAccess> {

src/api.ts:57

  • Ensure that the generateAuthorizeUri function is covered by tests to verify its behavior.
export async function generateAuthorizeUri(

src/api.ts:81

  • Ensure that the handleOAuthCallback function is covered by tests to verify its behavior.
export async function handleOAuthCallback(
@saebyn saebyn merged commit 581af06 into main Jan 7, 2025
3 checks passed
@saebyn saebyn deleted the saebyn/issue311 branch January 7, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move twitch login to backend API call, rather than exposing access token in URL in browser
1 participant